Refactor handling of Jinja2 templates and add filters #327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is @@ Coverage Diff @@
## develop #327 +/- ##
===========================================
+ Coverage 71.46% 72.45% +0.99%
===========================================
Files 87 91 +4
Lines 7990 8165 +175
Branches 1544 1572 +28
===========================================
+ Hits 5710 5916 +206
+ Misses 1875 1838 -37
- Partials 405 411 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes 🚀 New features to boost your workflow:
|
ogenstad
force-pushed
the
pog-jinja2-refactor
branch
3 times, most recently
from
c9d7233 to
b29559e
Compare
dgarros
approved these changes
Mar 28, 2025
github-actions
bot
added
the
type/documentation
ogenstad
force-pushed
the
pog-jinja2-refactor
branch
4 times, most recently
from
78400a5 to
cb7816b
Compare
BaptisteGi
reviewed
Mar 31, 2025
| --- | ||
|
|
||
|
|
||
| ## Builtin Jinja2 filters |
There was a problem hiding this comment.
Maybe worth pointing to the doc on this one (https://jinja.palletsprojects.com/en/stable/templates/#list-of-builtin-filters) so users know what's behind each line
There was a problem hiding this comment.
I've added these links.
ogenstad
force-pushed
the
pog-jinja2-refactor
branch
from
cb7816b to
66ac470
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the management of Jinja2 templates, some notes on this PR.
templateparameter as either astror apathlib.Pathobject, in the first case the template will be rendered from a string and the latter part will use file based templates.get_variables()method will return a list of any variables that are required by the template, a current limitation for now is that for file based templates this is only supported for the first file and not if the template includes other files as imports (this part can be added later, I just want to have it in place for the string based computed attributes and it's not used anywhere today)Note that we talked about providing a prefix for the netutils filters, though I'm not sure this is required now that we've listed the source of each filter within the documentation. Any thoughts around that?